Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump wrangler/lasso, client-go & k8s.io dependencies to k8s 1.30 #24

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Bump wrangler/lasso, client-go & k8s.io dependencies to k8s 1.30 #24

wants to merge 6 commits into from

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Jul 31, 2024 •
edited
Loading

  • Modify main.go to not use out-of-date rancher command libraries
  • Bump dependencies
  • Clean up generated code
  • Move tests to in-tree
  • Clean up CI files
  • Fix lock state mutability bug

@alexandreLamarre alexandreLamarre marked this pull request as ready for review July 31, 2024 17:35
@alexandreLamarre alexandreLamarre requested a review from a team as a code owner July 31, 2024 17:35
joshmeranda
joshmeranda approved these changes Jul 31, 2024
View reviewed changes
pkg/codegen/main.go
panic(err)
}
return
logrus.Infof("Generating code")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be pulled out of pkg/codegen/cleanup? Not necessarily a blocker just curious

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to be, but caused issues during the upgrade of dependencies

mallardduck
mallardduck approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@mallardduck mallardduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on a spot check.
Local builds work - did not deploy/test in a cluster though.

@mallardduck mallardduck mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmeranda joshmeranda joshmeranda approved these changes

@mallardduck mallardduck mallardduck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandreLamarre @mallardduck @joshmeranda